[riot-notifications] [RIOT-OS/RIOT] dhcpv6_client: refactor to use `event_timeout` for non-sock timeouts (#16668)

Marian Buschsieweke notifications at github.com
Fri Jul 23 11:42:06 CEST 2021

@maribu approved this pull request.

ACK. Change looks sane to me and I trust @kfessel testing. Please confirm that the potential issue I pointed out inline is indeed not present before hitting merge.

>      return (uint32_t)(xtimer_now_usec64() / US_PER_CS);
+static inline uint32_t _now_sec(void)

There is a potential footgun with using both timestamps from ZTIMER_SEC and ZTIMER_MSEC, as both could be provided by different hardware. One could (or at least I can see myself doing so) assume that the timestamps can be converted to each other.

I don't see this incorrect assumption anywhere here in the code, but I'm not really familiar with it.

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210723/95b5fddb/attachment.htm>

More information about the notifications mailing list