[riot-notifications] [RIOT-OS/RIOT] dhcpv6_client: mrd calculation for renew and rebind is wrong (#16677)

Karl Fessel notifications at github.com
Fri Jul 23 15:50:11 CEST 2021


#### Description

while reviewing #16668, hat a look at all of dhcpv6_clients time(r) calls i was not sure about the handling of rebind_time.

there are errors  in the use of rebind time and valid_time for the `mrd` calculation 

a printf in l.892 after the PR reveals the issue if one uses short T1 T2

```
printf("DHCPv6 client: mrd %"PRIu32" , etime %"PRIi16"\n", mrd, _get_elapsed_time() );
```

mrd ever increasing 

the issue is there before the PR and after the PR (they are generated by unchanged lines) i got no intend to search for them before PR

#### Steps to reproduce the issue

setup the dhcpv6 to issue short leases (there is a kea config with the dhcp client test)

and a printf to show MRD 

#### Expected results

the mrd printed should be ~constant 

#### Actual results

mrd is incresing ( it is the time the last lease was recived)

#### Versions

current and PR 16668

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/issues/16677
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210723/d6109d84/attachment-0001.htm>


More information about the notifications mailing list