[riot-notifications] [RIOT-OS/RIOT] FIDO2 support in RIOT (#16489)

Nils Ollrogge notifications at github.com
Mon Jul 26 20:25:30 CEST 2021


@Ollrogge commented on this pull request.



> +        else {
+            send_error_response(cid, CTAP_HID_ERR_CHANNEL_BUSY);
+            return;
+        }
+    }
+    else {
+        /* first init packet received starts a transaction */
+        if (is_init_type_pkt(pkt)) {
+            g_is_busy = true;
+            status = buffer_pkt(pkt);
+        }
+        /* ignore rest */
+    }
+
+    if (status == CTAP_HID_BUFFER_STATUS_ERROR) {
+        send_error_response(cid, g_state.err);

Since the function exists anyways after this If statement there is no need for a return. I could insert one though if it makes the code more readable ?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/16489#discussion_r676842642
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210726/e9ba62df/attachment-0001.htm>


More information about the notifications mailing list