[riot-notifications] [RIOT-OS/RIOT] sys/net/dhcpv6: Add IA_NA support to the DHCPv6 client (#16228)

Jan Romann notifications at github.com
Tue Jul 27 17:19:10 CEST 2021


@JKRhb commented on this pull request.



> @@ -828,6 +1055,16 @@ static void _request_renew_rebind(uint8_t type)
                     mrd = valid_until;
                 }
             }
+            if (IS_USED(MODULE_GNRC_DHCPV6_CLIENT_IA_NA)) {
+                /* calculate MRD from addr_leases */
+                for (unsigned i = 0; i < CONFIG_DHCPV6_CLIENT_ADDR_LEASE_MAX; i++) {
+                    const addr_lease_t *lease = &addr_leases[i];
+                    uint32_t valid_until = lease->valid_until / MS_PER_SEC;

I have to admit that I borrowed that code from `dhcpv6_client_conf_prefix` and `dhcpv6_client_prefix_valid_until`. I noticed only now that this conversion is only relevant for the NIB therefore removing the conversion makes a lot of sense. I was wondering, however, if the IA_NA addresses should somehow be integrated into the NIB as well? Or is it only relevant for delegated prefixes?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/16228#discussion_r677554862
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210727/ea153091/attachment.htm>


More information about the notifications mailing list