[riot-notifications] [RIOT-OS/RIOT] net/gnrc/ipv6: move gnrc_util_conf_prefix() to common code (#16672)

Martine Lenders notifications at github.com
Wed Jul 28 17:53:32 CEST 2021


@miri64 commented on this pull request.



> @@ -419,6 +419,18 @@ uint8_t gnrc_rpl_gen_instance_id(bool local)
     return instance_id;
 }
 
+void gnrc_rpl_configure_root(gnrc_netif_t *netif)
+{
+    gnrc_rpl_init(netif->pid);
+    gnrc_rpl_instance_t *inst = gnrc_rpl_instance_get(
+            CONFIG_GNRC_RPL_DEFAULT_INSTANCE
+        );
+    if (inst) {
+        gnrc_rpl_instance_remove(inst);
+    }
+    gnrc_rpl_root_init(CONFIG_GNRC_RPL_DEFAULT_INSTANCE, &addr, false, false);

Why not just provide it as a parameter? Guessing the address the DODAG should be opened on (is the one returned by `get_global()` really the one configured by the config protocol) seems like a bad idea. Not to mention that I do not see much use in such a guessing function in general.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/16672#discussion_r678437662
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210728/65744ebf/attachment.htm>


More information about the notifications mailing list