[riot-notifications] [RIOT-OS/RIOT] gnrc/nib: only consider neighbor cache entries as on-link in gnrc_ipv6_nib_get_next_hop_l2addr() (#16671)

Martine Lenders notifications at github.com
Thu Jul 29 12:35:55 CEST 2021


> * adds a missing `node->mode & _NC` check in `gnrc_ipv6_nib_get_next_hop_l2addr()` to ensure the entry is on-link

Not sure this is the right way to go. Only because an entry is not in the neighbor cache (yet), does not mean it is not on-link. A routing protocol (or for that matter a user using the `nib route` command) could have added that entry and the only thing missing for that entry to become a neighbor cache entry might be address resolution which would be triggered by sending to that neighbor.

> * adds a `_nib_onl_nc_get()` helper function to get rid of all those sprawling `(entry != NULL) && (entry->mode & _NC)` checks that are easy to forget / get wrong

That I don't argue with :-).


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/16671#issuecomment-889005605
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210729/bcecd3b8/attachment-0001.htm>


More information about the notifications mailing list