[riot-notifications] [RIOT-OS/RIOT] makefiles/clang-tidy: initial support (#16509)

Alexandre Abadie notifications at github.com
Tue Jun 1 10:42:01 CEST 2021


@aabadie commented on this pull request.



> +# inlcude clang-tidy
+include $(RIOTMAKE)/clang_tidy.inc.mk

Why not only include this if llvm toolchain is used (there's also a typo btw):

```suggestion
# include clang-tidy if llvm toolchain is used
ifeq (llvm,$(TOOLCHAIN))
  include $(RIOTMAKE)/clang_tidy.inc.mk
endif
```

Then there's no need for the error message in `clang_tidy.inc.mk` (that I would rename `clang-tidy.inc.mk` but that's a matter of taste and I won't insist)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/16509#pullrequestreview-672808795
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210601/a5a92fd9/attachment.htm>


More information about the notifications mailing list