[riot-notifications] [RIOT-OS/RIOT] tests/riotboot/flashwrite: add automatic test (#15559)

Alexandre Abadie notifications at github.com
Tue Jun 1 13:50:21 CEST 2021


@aabadie commented on this pull request.



>  
     int current_slot = riotboot_slot_current();
-    printf("Current slot=%d\n", current_slot);
-    riotboot_slot_print_hdr(current_slot);
+    if (current_slot != -1) {
+        /* Sometimes, udhcp output messes up the following printfs.  That
+         * confuses the test script. As a workaround, just disable interrupts
+         * for a while.
+         */
+        unsigned state = irq_disable();
+        riotboot_slot_print_hdr(current_slot);
+        irq_restore(state);
+    }
+    else {
+        printf("[FAILED] You're not running riotboot\n");

```suggestion
        puts("[FAILED] You're not running riotboot");
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/15559#pullrequestreview-672974784
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210601/58caa696/attachment.htm>


More information about the notifications mailing list