[riot-notifications] [RIOT-OS/RIOT] tools/iotlab-tested: several improvements in single board support (#16501)

Francisco notifications at github.com
Tue Jun 1 15:54:22 CEST 2021


@fjmolinas commented on this pull request.

A single comment, otherwise I reproduced the test procedure, all good, you can squash right away.

> @@ -137,6 +137,24 @@ ifeq (auto,$(IOTLAB_NODE))
   endif
 endif
 
+# Handle IOTLAB_NODE specified with comma separated form
+# saclay,m3,1 => m3-1.saclay.iot-lab.info)
+_COMMA := ,

Can't you use already defined `comma` makefiles/utils/variables.mk

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/16501#pullrequestreview-673100392
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210601/c999b6fb/attachment.htm>


More information about the notifications mailing list