[riot-notifications] [RIOT-OS/RIOT] pkg/pkg.mk: avoid git fetch if commit is already there (#16514)

Francisco notifications at github.com
Wed Jun 2 14:35:24 CEST 2021


> > can you fix authorship of your commit?
> 
> is it really worth ? I rewrote most of the original change. Should we put authorship to any person just because we take inspiration of his/her code ?

Your PR said take over, usually, that means you took their code rebase/adapted and PR'd, in that case, yes, authorship is due. Otherwise, it's not really a take over is it? My comment was based on that, I did not really compare both PR's in details, so if you indeed re-implemented most of it then do as you think is best.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/16514#issuecomment-852989496
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210602/d2766305/attachment.htm>


More information about the notifications mailing list