[riot-notifications] [RIOT-OS/RIOT] net/gcoap: change return type from gcoap_req_send() to ssize_t (#16526)

János Brodbeck notifications at github.com
Fri Jun 4 17:02:50 CEST 2021

The RIOT community cares a lot about code quality.
Therefore, before describing what your contribution is about, we would like
you to make sure that your modifications are compliant with the RIOT
coding conventions, see https://github.com/RIOT-OS/RIOT/wiki/Coding-conventions.

### Contribution description
`gcoap_req_send()` does not allow returning negative values to indicate errors. For the support of DTLS in gcoap it is useful to return error codes here to specify what went wrong (e.g. authentication failed) and not only return that 0 bytes were sent. 

This PR only changes the return type from `size_t` to `ssize_t` to allow this.
Put here the description of your contribution:
- describe which part(s) of RIOT is (are) involved
- if it's a bug fix, describe the bug that it solves and how it is solved
- you can also give more information to reviewers about how to test your changes

### Testing procedure

Reading and compiling examples/gcoap should be enough. It works the same as before.

### Issues/PRs references

Examples: Fixes #1234. See also #5678. Depends on PR #9876.

Please use keywords (e.g., fixes, resolve) with the links to the issues you
resolved, this way they will be automatically closed when your pull request
is merged. See https://help.github.com/articles/closing-issues-using-keywords/.

You can view, comment on, or merge this pull request online at:


-- Commit Summary --

  * net/gcoap: change return type from gcoap_req_send() to ssize_t

-- File Changes --

    M sys/include/net/gcoap.h (6)
    M sys/net/application_layer/gcoap/gcoap.c (6)

-- Patch Links --


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210604/0a546b6b/attachment-0001.htm>

More information about the notifications mailing list