[riot-notifications] [RIOT-OS/RIOT] build-system: auto-locate modules by name (#16465)

Marian Buschsieweke notifications at github.com
Tue Jun 8 11:28:01 CEST 2021


@maribu commented on this pull request.



> @@ -698,6 +698,7 @@ ifneq (,$(filter xtimer,$(USEMODULE)))
     endif
   else
   # ztimer_xtimer_compat is used, all of *xtimer's API will be mapped on ztimer.*
+  NO_AUTOLOCATE += xtimer

The location of modules is done fully again at each recursion step. If xtimer would be auto-located in a transient state, it would be dropped later on. But some care should be taken so that an `Makefile.dep` doesn't do anything `xtimer` related when `ztimer_xtimer_compat` is also used. But since there is no `Makefile.dep` in `sys/xtimer` and in `sys/Makefile.dep` (above code) the correct guards are in place, this should just work.

A bit of a foot gun, but choosing different implementation options for the same API is just not properly modeled in the build system, so some friction is expected.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/16465#discussion_r647276462
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210608/08bd532d/attachment-0001.htm>


More information about the notifications mailing list