[riot-notifications] [RIOT-OS/RIOT] gnrc_ipv6_nib: auto-configure downstream subnets (#16536)

Martine Lenders notifications at github.com
Tue Jun 8 12:31:58 CEST 2021


@miri64 commented on this pull request.



> +        if (downstream == upstream) {
+            continue;
+        }

What if there are supposed to be multiple `upstreams`?

> @@ -41,6 +41,7 @@ PSEUDOMODULES += gnrc_ipv6_nib_6ln
 PSEUDOMODULES += gnrc_ipv6_nib_6lr
 PSEUDOMODULES += gnrc_ipv6_nib_dns
 PSEUDOMODULES += gnrc_ipv6_nib_router
+PSEUDOMODULES += gnrc_ipv6_nib_subnets

I'd prefer this its own "routing protocol" rather than a sub-module of the NIB. Making it a sub-module makes it look like it is an "official" feature of IPv6, while this more of a flashy hack than anything else. It should be doable with an "route changed" event.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/16536#pullrequestreview-678352011
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210608/1125b010/attachment-0001.htm>


More information about the notifications mailing list