[riot-notifications] [RIOT-OS/RIOT] pkg/nimble/netif: fix and optimize NimBLE buffer sizes (#16503)

Hauke Petersen notifications at github.com
Thu Jun 10 09:44:22 CEST 2021


@haukepetersen commented on this pull request.



> +  # WARNING: this value MUST never be larger than MYNEWT_VAL_BLE_LL_MAX_PKT_SIZE
+  CFLAGS += -DMYNEWT_VAL_BLE_L2CAP_COC_MPS=251

Difficult situation: 
1. this condition does only apply, if we use the NimBLE controller. If we would build NimBLE against another controller, it would not apply anymore...
2. structural, this check would need to go into NimBLE and not RIOT. But I have no idea currently how to implement it there in a clean way.
3. As we define this value here as a constant and as we don't allow to override this from the build system, I think we should be safe without that check. If anyone starts to mess with this value, I'd say its up to them to read the warning above.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/16503#discussion_r648932555
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210610/aedaa282/attachment.htm>


More information about the notifications mailing list