[riot-notifications] [RIOT-OS/RIOT] pkg/nimble/netif: fix and optimize NimBLE buffer sizes (#16503)

Hauke Petersen notifications at github.com
Thu Jun 10 10:10:51 CEST 2021


(selected) output of `tests/nimble_l2cap`:
```
inctest:
2021-06-10 10:05:13,741 # # Sending: size  4958 seq   496
2021-06-10 10:05:13,941 # # Sending: size  4968 seq   497
2021-06-10 10:05:14,141 # # Sending: size  4978 seq   498
2021-06-10 10:05:14,341 # # Sending: size  4988 seq   499
2021-06-10 10:05:14,573 # # Sending: size  4998 seq   500
2021-06-10 10:05:14,740 # # TEST COMPLETE
2021-06-10 10:05:14,741 # -> runtime: 67948ms

flood with large packets:
2021-06-10 10:05:49,252 # # Sending: size  5000 seq    97
2021-06-10 10:05:49,493 # # Sending: size  5000 seq    98
2021-06-10 10:05:49,752 # # Sending: size  5000 seq    99
2021-06-10 10:05:49,952 # # Sending: size  5000 seq   100
2021-06-10 10:05:50,616 # # TEST COMPLETE
2021-06-10 10:05:50,618 # -> runtime: 22640ms
2021-06-10 10:05:50,619 # -> ~ 22305 bytes/s
```

IP over BLE (`examples/gnrc_networking` @ `nrf52dk`):
Sending large payloads (> `MYNEWT_VAL_BLE_LL_MAX_PKT_SIZE`) with master fails:
```
> ping FE80::CE57:7AFF:FE19:D737 -s 200
2021-06-10 10:09:57,314 # ping FE80::CE57:7AFF:FE19:D737 -s 200
2021-06-10 10:09:57,386 # 208 bytes from fe80::ce57:7aff:fe19:d737%8: icmp_seq=0 ttl=64 time=65.309 ms
2021-06-10 10:09:58,386 # 208 bytes from fe80::ce57:7aff:fe19:d737%8: icmp_seq=1 ttl=64 time=62.503 ms
2021-06-10 10:09:59,386 # 208 bytes from fe80::ce57:7aff:fe19:d737%8: icmp_seq=2 ttl=64 time=59.831 ms
2021-06-10 10:09:59,387 # 
2021-06-10 10:09:59,391 # --- FE80::CE57:7AFF:FE19:D737 PING statistics ---
2021-06-10 10:09:59,396 # 3 packets transmitted, 3 packets received, 0% packet loss
2021-06-10 10:09:59,400 # round-trip min/avg/max = 59.831/62.547/65.309 ms
> ping FE80::CE57:7AFF:FE19:D737 -s 1000
2021-06-10 10:10:05,736 # ping FE80::CE57:7AFF:FE19:D737 -s 1000
2021-06-10 10:10:08,745 # 
2021-06-10 10:10:08,749 # --- FE80::CE57:7AFF:FE19:D737 PING statistics ---
2021-06-10 10:10:08,754 # 3 packets transmitted, 0 packets received, 100% packet loss
> ping FE80::CE57:7AFF:FE19:D737 -s 1200
2021-06-10 10:10:12,147 # ping FE80::CE57:7AFF:FE19:D737 -s 1200
2021-06-10 10:10:15,155 # 
2021-06-10 10:10:15,159 # --- FE80::CE57:7AFF:FE19:D737 PING statistics ---
2021-06-10 10:10:15,164 # 3 packets transmitted, 0 packets received, 100% packet loss
```
Doing the same with this PR works as expected:
```
> ping FE80::CE57:7AFF:FE19:D737 -s 200
2021-06-10 10:08:28,306 # ping FE80::CE57:7AFF:FE19:D737 -s 200
2021-06-10 10:08:28,409 # 208 bytes from fe80::ce57:7aff:fe19:d737%8: icmp_seq=0 ttl=64 time=96.317 ms
2021-06-10 10:08:29,409 # 208 bytes from fe80::ce57:7aff:fe19:d737%8: icmp_seq=1 ttl=64 time=94.094 ms
2021-06-10 10:08:30,409 # 208 bytes from fe80::ce57:7aff:fe19:d737%8: icmp_seq=2 ttl=64 time=91.751 ms
2021-06-10 10:08:30,409 # 
2021-06-10 10:08:30,414 # --- FE80::CE57:7AFF:FE19:D737 PING statistics ---
2021-06-10 10:08:30,419 # 3 packets transmitted, 3 packets received, 0% packet loss
2021-06-10 10:08:30,423 # round-trip min/avg/max = 91.751/94.054/96.317 ms
> ping FE80::CE57:7AFF:FE19:D737 -s 1000
2021-06-10 10:08:35,203 # ping FE80::CE57:7AFF:FE19:D737 -s 1000
2021-06-10 10:08:35,320 # 1008 bytes from fe80::ce57:7aff:fe19:d737%8: icmp_seq=0 ttl=64 time=108.702 ms
2021-06-10 10:08:36,320 # 1008 bytes from fe80::ce57:7aff:fe19:d737%8: icmp_seq=1 ttl=64 time=106.448 ms
2021-06-10 10:08:37,320 # 1008 bytes from fe80::ce57:7aff:fe19:d737%8: icmp_seq=2 ttl=64 time=104.226 ms
2021-06-10 10:08:37,321 # 
2021-06-10 10:08:37,324 # --- FE80::CE57:7AFF:FE19:D737 PING statistics ---
2021-06-10 10:08:37,329 # 3 packets transmitted, 3 packets received, 0% packet loss
2021-06-10 10:08:37,334 # round-trip min/avg/max = 104.226/106.458/108.702 ms
> ping FE80::CE57:7AFF:FE19:D737 -s 1200
2021-06-10 10:08:40,638 # ping FE80::CE57:7AFF:FE19:D737 -s 1200
2021-06-10 10:08:40,725 # 1208 bytes from fe80::ce57:7aff:fe19:d737%8: icmp_seq=0 ttl=64 time=79.663 ms
2021-06-10 10:08:41,722 # 1208 bytes from fe80::ce57:7aff:fe19:d737%8: icmp_seq=1 ttl=64 time=75.369 ms
2021-06-10 10:08:42,722 # 1208 bytes from fe80::ce57:7aff:fe19:d737%8: icmp_seq=2 ttl=64 time=73.297 ms
2021-06-10 10:08:42,722 # 
2021-06-10 10:08:42,727 # --- FE80::CE57:7AFF:FE19:D737 PING statistics ---
2021-06-10 10:08:42,732 # 3 packets transmitted, 3 packets received, 0% packet loss
2021-06-10 10:08:42,736 # round-trip min/avg/max = 73.297/76.109/79.663 ms
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/16503#issuecomment-858410587
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210610/392d27e1/attachment-0001.htm>


More information about the notifications mailing list