[riot-notifications] [RIOT-OS/RIOT] drivers/slipdev: report NETOPT_ADDRESS to simulate l2 address (#16531)

Martine Lenders notifications at github.com
Fri Jun 11 09:45:00 CEST 2021


@miri64 commented on this pull request.



> @@ -143,7 +143,7 @@ extern "C" {
  *       address types are included
  */
 #ifndef GNRC_NETIF_L2ADDR_MAXLEN
-#if defined(MODULE_NETDEV_IEEE802154) || defined(MODULE_XBEE)
+#if defined(MODULE_NETDEV_IEEE802154) || defined(MODULE_XBEE) || defined(MODULE_SLIPDEV)

```suggestion
#if defined(MODULE_NETDEV_IEEE802154) || defined(MODULE_XBEE) || defined(MODULE_SLIPDEV_L2ADDR)
```

>  {
     /* set device descriptor fields */
     dev->config = *params;
     dev->state = 0;
     dev->netdev.driver = &slip_driver;
+
+    netdev_register(&dev->netdev, NETDEV_SLIPDEV, index);

Shouldn't this be wrapped with `MODULE_SLIPDEV_L2ADDR` as well now? As far as I understood you, this is what caused the problem in the first place.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/16531#pullrequestreview-681542600
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210611/f2aced2b/attachment.htm>


More information about the notifications mailing list