[riot-notifications] [RIOT-OS/RIOT] gnrc_ipv6_nib: add full RFC4862 DAD support (#8823)

benpicco notifications at github.com
Mon Jun 14 19:36:23 CEST 2021

@benpicco commented on this pull request.

> @@ -838,9 +837,30 @@ static void _handle_nbr_sol(gnrc_netif_t *netif, const ipv6_hdr_t *ipv6,
     DEBUG("     - Destination address: %s\n",
           ipv6_addr_to_str(addr_str, &ipv6->dst, sizeof(addr_str)));
-    /* TODO SLAAC behavior */
+    gnrc_netif_t *tgt_netif = gnrc_netif_get_by_ipv6_addr(&nbr_sol->tgt);

Why is `tgt_netif` not used earlier/all the time?

    tgt_idx = gnrc_netif_ipv6_addr_idx(netif, &nbr_sol->tgt);
    if (tgt_idx < 0) {
        DEBUG("nib: Target address %s is not assigned to the local interface\n",
              ipv6_addr_to_str(addr_str, &nbr_sol->tgt, sizeof(addr_str)));

fails if the requested address is on a different interface than the one where the request was received. 

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210614/e1ed00c0/attachment-0001.htm>

More information about the notifications mailing list