[riot-notifications] [RIOT-OS/RIOT] pkg/mynewt-core: initial commit (#16348)

Hauke Petersen notifications at github.com
Tue Jun 15 09:48:11 CEST 2021


@haukepetersen commented on this pull request.



> @@ -0,0 +1,1930 @@
+From eadc071053d2c929f88b2721d57f49ec351fc035 Mon Sep 17 00:00:00 2001
+From: Francisco Molina <femolina at uc.cl>
+Date: Mon, 19 Apr 2021 15:48:50 +0200
+Subject: [PATCH 1/4] riot: add interested header symlinks
+
+---
+ riot/include/hal/hal_timer.h   |   1 +

1. and 3. I really don't like: symlinks are IMO quite error prone, and everything depending on the order of include paths will (at least with our current build system) explode at some point and will be quite nasty to debug...
2. although this could easily lead to a situation where the copied header get out of sync with their upstream versions, this seems to be slightly cleaner to me...

A fork seems to be a nice option to me. The benefit I see, is that this would make it much easier for us to have a plain view on the files actually used. But this would still leave the problem in keeping the fork and the upstream mynewt repo in sync...

Aside from those options, I think I have another one we could consider: How about simply deleting the headers we are not using from the include dir? This would be a 2 liner in the Makefile and if we put the list of files to delete in a simple variable these two lines would also very easy to maintain, right?!

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/16348#discussion_r651535781
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210615/3e514f27/attachment-0001.htm>


More information about the notifications mailing list