[riot-notifications] [RIOT-OS/RIOT] cpu/stm32: Add Kconfig dependency modeling (#16483)

Leandro Lanzieri notifications at github.com
Tue Jun 15 11:28:13 CEST 2021


@leandrolanzieri commented on this pull request.



> +config MODULE_CPP
+    bool
+    depends on TEST_KCONFIG
+    depends on HAS_CPP
+
+config MODULE_LIBSTDCPP
+    bool
+    depends on TEST_KCONFIG
+    depends on HAS_LIBSTDCPP
+

I think these should be visible, and enabling libstdc++ depends on having c++ enabled:

```suggestion
menuconfig MODULE_CPP
    bool "C++ support"
    depends on TEST_KCONFIG
    depends on HAS_CPP

config MODULE_LIBSTDCPP
    bool "libstdc++ support"
    depends on MODULE_CPP
    depends on HAS_LIBSTDCPP

```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/16483#pullrequestreview-683773721
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210615/2e6ae429/attachment-0001.htm>


More information about the notifications mailing list