[riot-notifications] [RIOT-OS/RIOT] gnrc_dhcpv6_client_6lbr: choose downstream if as !upstream (#16530)

Martine Lenders notifications at github.com
Tue Jun 15 15:00:42 CEST 2021


@miri64 commented on this pull request.

You forgot to define the greedy sub-module ;-).

> @@ -101,8 +101,13 @@ static void _configure_upstream_netif(gnrc_netif_t *upstream_netif)
 static void _configure_dhcpv6_client(void)
 {
     gnrc_netif_t *netif = NULL;
+    gnrc_netif_t *upstream = _find_upstream_netif();

```suggestion
    gnrc_netif_t *upstream = (IS_USED(MODULE_GNRC_DHCPV6_CLIENT_GREEDY))
                           ? _find_upstream_netif() : NULL;
```

> +        if (netif != upstream) {
             dhcpv6_client_req_ia_pd(netif->pid, 64U);
         }

```suggestion
        if (IS_USED(MODULE_GNRC_DHCPV6_CLIENT_GREEDY) &&
            (netif == upstream)) {
            continue
        }
        dhcpv6_client_req_ia_pd(netif->pid, 64U);
```

>  ifneq (,$(filter gnrc_dhcpv6_client_6lbr,$(USEMODULE)))
+  USEMODULE += gnrc_dhcpv6_client_simple_pd
+endif

```suggestion
ifneq (,$(filter gnrc_dhcpv6_client_6lbr,$(USEMODULE)))
  USEMODULE += gnrc_dhcpv6_client_simple_pd
endif

ifneq (,$(filter gnrc_dhcpv6_client_greedy,$(USEMODULE)))
  USEMODULE += gnrc_dhcpv6_client_simple_pd
endif
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/16530#pullrequestreview-683971537
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210615/be3a709d/attachment-0001.htm>


More information about the notifications mailing list