[riot-notifications] [RIOT-OS/RIOT] gnrc_dhcpv6_client_6lbr: choose downstream if as !upstream (#16530)

benpicco notifications at github.com
Tue Jun 15 15:06:34 CEST 2021


@benpicco commented on this pull request.



> +        if (netif != upstream) {
             dhcpv6_client_req_ia_pd(netif->pid, 64U);
         }

I don't see why we would want that, now if only `gnrc_dhcpv6_client_simple_pd` is selected this is a bug as also the upstream interface is selected for prefix delegation.

I think there is no need for a 'greedy' module: `gnrc_dhcpv6_client_simple_pd` could just be greedy by default if not specified otherwise (e.g. by excluding non-6lo interfaces) 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/16530#discussion_r651770900
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210615/762b7da8/attachment.htm>


More information about the notifications mailing list