[riot-notifications] [RIOT-OS/RIOT] gnrc_ipv6_nib: add full RFC4862 DAD support (#8823)

Martine Lenders notifications at github.com
Tue Jun 15 16:11:58 CEST 2021


@miri64 commented on this pull request.



> @@ -838,9 +837,30 @@ static void _handle_nbr_sol(gnrc_netif_t *netif, const ipv6_hdr_t *ipv6,
     DEBUG("     - Destination address: %s\n",
           ipv6_addr_to_str(addr_str, &ipv6->dst, sizeof(addr_str)));
 #if GNRC_IPV6_NIB_CONF_SLAAC
-    /* TODO SLAAC behavior */
+    gnrc_netif_t *tgt_netif = gnrc_netif_get_by_ipv6_addr(&nbr_sol->tgt);

> Now the NS is answered for all interfaces, but why is the neighbor sending a NS for the second interface in the first place when it should instead just route the packet to the next hop (`2001:16b8:45b5:9af8:5884:3bff:fe4f:a903%7`).

Ah now I got the sentence. Well is the next hop in the neighbor cache already? If not, NDP needs to find the neighbor first. Just because it is in the FIB does not mean the node is reachable under the definition of NDP.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/8823#discussion_r651831693
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210615/957e4bd2/attachment.htm>


More information about the notifications mailing list