[riot-notifications] [RIOT-OS/RIOT] FIDO2 support in RIOT (#16489)

Nils Ollrogge notifications at github.com
Wed Jun 16 18:46:44 CEST 2021


@Ollrogge commented on this pull request.



> +    }
+
+    memmove(r_raw, sig, sizeof(r_raw));
+    memmove(s_raw, sig + sizeof(r_raw), sizeof(s_raw));
+
+    ret = sig_to_der_format(r_raw, s_raw, sig, sig_size);
+
+    if (ret != CTAP2_OK) {
+        return ret;
+    }
+
+    return CTAP2_OK;
+}
+
+/* Encode signature in ASN.1 DER format */
+static int sig_to_der_format(uint8_t *r, uint8_t *s, uint8_t *sig,

No it is not. Extracting it and adding dedicated tests is a good idea. 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/16489#discussion_r652867533
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210616/dee0fcb8/attachment-0001.htm>


More information about the notifications mailing list