[riot-notifications] [RIOT-OS/RIOT] gnrc/nib: fix starting with router advertisements disabled, enabling them at run-time (#16567)

Martine Lenders notifications at github.com
Thu Jun 17 19:03:51 CEST 2021


@miri64 commented on this pull request.

> It's already defined in `_nib-router.h`, defining it to no-op in `_nib-6lr.h` makes it impossible to run-time enable advertisements on non 6lo nodes.

Do you mean non-routing nodes? Why should they be able to advertise themselves as routers?

> -    if (!IS_ACTIVE(CONFIG_GNRC_IPV6_NIB_6LR) ||
-        IS_ACTIVE(CONFIG_GNRC_IPV6_NIB_6LBR)) {
+    if (IS_ACTIVE(CONFIG_GNRC_IPV6_NIB_ADV_ROUTER)) {

This isn't the same. A non border router 6LR still needs to start without router advertisements being active. See https://datatracker.ietf.org/doc/html/rfc6775#section-6.2. How about, to make the option usable we either do

```suggestion
    if ((!IS_ACTIVE(CONFIG_GNRC_IPV6_NIB_6LR) ||
         IS_ACTIVE(CONFIG_GNRC_IPV6_NIB_6LBR)) &&
        IS_ACTIVE(CONFIG_GNRC_IPV6_NIB_ADV_ROUTER)) {
```

Here or make `!IS_ACTIVE(CONFIG_GNRC_IPV6_NIB_6LR) || IS_ACTIVE(CONFIG_GNRC_IPV6_NIB_6LBR)` the default for `CONFIG_GNRC_IPV6_NIB_ADV_ROUTER`?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/16567#pullrequestreview-686580717
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210617/eb3ded41/attachment.htm>


More information about the notifications mailing list