[riot-notifications] [RIOT-OS/RIOT] gnrc/nib: fix starting with router advertisements disabled, enabling them at run-time (#16567)

Martine Lenders notifications at github.com
Thu Jun 17 19:13:17 CEST 2021


@miri64 commented on this pull request.



> -    if (!IS_ACTIVE(CONFIG_GNRC_IPV6_NIB_6LR) ||
-        IS_ACTIVE(CONFIG_GNRC_IPV6_NIB_6LBR)) {
+    if (IS_ACTIVE(CONFIG_GNRC_IPV6_NIB_ADV_ROUTER)) {

Then again... this should be more dynamically configured, I believe. So assuming these flags are already set, it should be

```suggestion
    if ((!gnrc_netif_is_6lr(netif) ||
         gnrc_netif_is_6lbr(netif)) &&
        IS_ACTIVE(CONFIG_GNRC_IPV6_NIB_ADV_ROUTER)) {
```

which makes the setting  as a default for `ADV_ROUTER` impossible of course.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/16567#discussion_r653770513
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210617/62fb21f0/attachment-0001.htm>


More information about the notifications mailing list