[riot-notifications] [RIOT-OS/RIOT] gnrc_ipv6_nib: consider all local interfaces when looking for address (#16569)

Martine Lenders notifications at github.com
Fri Jun 18 07:18:55 CEST 2021


@miri64 commented on this pull request.



> -        gnrc_ndp_nbr_adv_send(&nbr_sol->tgt, netif, &ipv6->src, false, NULL);
+        gnrc_ndp_nbr_adv_send(&nbr_sol->tgt, tgt_netif, &ipv6->src, false, NULL);

>From what I understand If the neighbor is solicited via `netif` corresponds interface A in your description and `tgt_netif` interface B. Shouldn't the neighbor advertisement go out the same interface (`netif`) the solicitation was received on?

> @@ -1013,10 +1021,10 @@ static void _handle_nbr_sol(gnrc_netif_t *netif, const ipv6_hdr_t *ipv6,
         reply_aro = _copy_and_handle_aro(netif, ipv6, nbr_sol, aro, sl2ao);
         /* check if target address is anycast */
         if (netif->ipv6.addrs_flags[tgt_idx] & GNRC_NETIF_IPV6_ADDRS_FLAGS_ANYCAST) {
-            _send_delayed_nbr_adv(netif, &nbr_sol->tgt, ipv6, reply_aro);
+            _send_delayed_nbr_adv(tgt_netif, &nbr_sol->tgt, ipv6, reply_aro);

Same here

>          }
         else {
-            gnrc_ndp_nbr_adv_send(&nbr_sol->tgt, netif, &ipv6->src,
+            gnrc_ndp_nbr_adv_send(&nbr_sol->tgt, tgt_netif, &ipv6->src,

And here.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/16569#pullrequestreview-687038006
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210617/623e734d/attachment.htm>


More information about the notifications mailing list