[riot-notifications] [RIOT-OS/RIOT] drivers/sx126x: fix netdev send function (#16570)
notifications at github.com
Fri Jun 18 10:11:23 CEST 2021
The RIOT community cares a lot about code quality.
Therefore, before describing what your contribution is about, we would like
you to make sure that your modifications are compliant with the RIOT
coding conventions, see https://github.com/RIOT-OS/RIOT/wiki/Coding-conventions.
### Contribution description
This commit fixes the send function of sx126x. The loop that reads the
iolist was not considering the offset. Therefore each iolist snippet was
being written into the first position.
The loop was also setting the payload length to the size of the iolist
snippet. Then the payload was also wrong.
With this commit an iolist is copied sequentially into the framebuffer
and the payload length is set to `iolist_size`.
Put here the description of your contribution:
- describe which part(s) of RIOT is (are) involved
- if it's a bug fix, describe the bug that it solves and how it is solved
- you can also give more information to reviewers about how to test your changes
### Testing procedure
Trigger a Join Request using GNRC LoRaWAN. Neither `tests/driver_sx126x` nor Semtech LoRaMAC use an iolist with more than one snippet, so they won't show this issue.
Details steps to test your contribution:
- which test/example to compile for which board and is there a 'test' command
- how to know that it was not working/available in master
- the expected success test output
### Issues/PRs references
None so far
Examples: Fixes #1234. See also #5678. Depends on PR #9876.
Please use keywords (e.g., fixes, resolve) with the links to the issues you
resolved, this way they will be automatically closed when your pull request
is merged. See https://help.github.com/articles/closing-issues-using-keywords/.
You can view, comment on, or merge this pull request online at:
-- Commit Summary --
* drivers/sx126x: fix netdev send function
-- File Changes --
M drivers/sx126x/sx126x_netdev.c (7)
-- Patch Links --
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the notifications