[riot-notifications] [RIOT-OS/RIOT] sys/net/gcoap: allow seperate response (#16578)
notifications at github.com
Tue Jun 22 17:10:33 CEST 2021
The RIOT community cares a lot about code quality.
Therefore, before describing what your contribution is about, we would like
you to make sure that your modifications are compliant with the RIOT
coding conventions, see https://github.com/RIOT-OS/RIOT/wiki/Coding-conventions.
### Contribution description
Put here the description of your contribution:
- describe which part(s) of RIOT is (are) involved
- if it's a bug fix, describe the bug that it solves and how it is solved
- you can also give more information to reviewers about how to test your changes
Gcoap doesn't allow sending separate responses on CON messages (see #14393). This can be useful if it is known ahead that computations on the server will take longer. Otherwise the client will retransmit the request and a timeout will occur.
This PR allows to choose separate responses instead of piggybacked responses for a resource. It does not allow to send separate responses per request by the handler itself (as suggested in #14395), but is done by gcoap in case this was selected for a resource.
### Testing procedure
Details steps to test your contribution:
- which test/example to compile for which board and is there a 'test' command
- how to know that it was not working/available in master
- the expected success test output
Start a gcoap server and GET from a client `/riot/board` (as CON message). Observing it with Wireshark shows that an Empty response message is sent before the actual response is sent.
### Issues/PRs references
See also #14395, #14393
Examples: Fixes #1234. See also #5678. Depends on PR #9876.
Please use keywords (e.g., fixes, resolve) with the links to the issues you
resolved, this way they will be automatically closed when your pull request
is merged. See https://help.github.com/articles/closing-issues-using-keywords/.
You can view, comment on, or merge this pull request online at:
-- Commit Summary --
* seperate response in gcoap
-- File Changes --
M examples/gcoap/gcoap_cli.c (4)
M sys/include/net/gcoap.h (5)
M sys/include/net/nanocoap.h (3)
M sys/net/application_layer/gcoap/gcoap.c (23)
-- Patch Links --
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the notifications