[riot-notifications] [RIOT-OS/RIOT] gnrc_netif: remove NETDEV_MSG_TYPE_EVENT processing from thread (#13608)

Marian Buschsieweke notifications at github.com
Thu Jun 24 15:07:50 CEST 2021


@maribu commented on this pull request.

code looks good to me. One style issue (please squash / amend directly).

This doesn't look scary to me, so I would insist on full testing. I will test on the CC1101 to at least provide some test coverage.

> +    switch(msg->type) {
+        case NETDEV_MSG_TYPE_EVENT:
+            DEBUG("gnrc_netif: GNRC_NETDEV_MSG_TYPE_EVENT received\n");
+            dev->driver->isr(dev);
+            break;
+        default:
+            break;
+    }

```suggestion
    switch (msg->type) {
    case NETDEV_MSG_TYPE_EVENT:
        DEBUG("gnrc_netif: GNRC_NETDEV_MSG_TYPE_EVENT received\n");
        dev->driver->isr(dev);
        break;
    default:
        break;
    }
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/13608#pullrequestreview-691726231
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210624/0ff94615/attachment.htm>


More information about the notifications mailing list