[riot-notifications] [RIOT-OS/RIOT] cpu/stm32: Add Kconfig dependency modeling (#16483)

Leandro Lanzieri notifications at github.com
Fri Jun 25 10:58:54 CEST 2021


@leandrolanzieri commented on this pull request.



> @@ -67,9 +67,11 @@ ifeq ($(strip $(ASSMSRC))$(NO_AUTO_SRC),)
   ASSMSRC := $(wildcard *.S)
 endif
 
-ifneq (,$(SRCXX))
-  ifeq (,$(filter cpp,$(FEATURES_USED)))
-    $(error Found C++ source, but feature "cpp" is not used. Add "FEATURES_REQUIRED += cpp")
+ifneq (1,$(TEST_KCONFIG))
+  ifneq (,$(SRCXX))
+    ifeq (,$(filter cpp,$(FEATURES_USED)))
+      $(error Found C++ source, but feature "cpp" is not used. Add "FEATURES_REQUIRED += cpp")

How is this checked when using Kconfig?

> @@ -6,8 +6,7 @@ ifneq (,$(filter arduino,$(USEMODULE)))
   FEATURES_REQUIRED += cpp
   FEATURES_REQUIRED += periph_gpio
   FEATURES_REQUIRED += periph_uart
-  SKETCH_MODULE ?= arduino_sketches
-  USEMODULE += $(SKETCH_MODULE)
+  USEMODULE += arduino_sketches

It seems like this does more than 'fix kconfig of arduino', probably worth its own commit at least.

> @@ -0,0 +1,17 @@
+# Copyright (c) 2021 HAW Hamburg
+#
+# This file is subject to the terms and conditions of the GNU Lesser
+# General Public License v2.1. See the file LICENSE in the top level
+# directory for more details.
+#
+
+if TEST_KCONFIG
+
+config MODULE_BOARDS_COMMON_NUCLEO
+    bool
+    default y
+    select MODULE_SAUL_GPIO if MODULE_SAUL_DEFAULT

should `HAS_PERIPH_GPIO` be checked here?

> +    help
+        stm32 can bus peripheral.

No sure about the help string, how is this resolved against the other definition?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/16483#pullrequestreview-692608353
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210625/0166931f/attachment.htm>


More information about the notifications mailing list