[riot-notifications] [RIOT-OS/RIOT] gnrc_ipv6_nib: handle route information option (#16568)

Martine Lenders notifications at github.com
Mon Jun 28 09:35:45 CEST 2021


@miri64 requested changes on this pull request.



> -
-    /* Disable router advertisements on upstream interface. With this, the border
-     * router
-     * 1. Does not confuse the upstream router to add the border router to its
-     *    default router list and
-     * 2. Solicits upstream Router Advertisements quicker to auto-configure its
-     *    upstream global address.
-     */

This comment disappeared if I am not mistaken

> @@ -174,6 +174,17 @@ void dhcpv6_client_conf_prefix(unsigned iface, const ipv6_addr_t *pfx,
             gnrc_rpl_root_init(CONFIG_GNRC_RPL_DEFAULT_INSTANCE, &addr, false, false);
         }
     }
+
+    /* start advertising subnet */
+    gnrc_ipv6_nib_change_rtr_adv_iface(netif, true);
+}
+
+void dhcpv6_client_conf_done(unsigned iface)
+{
+    gnrc_netif_t *netif = gnrc_netif_get_by_pid(iface);
+
+    /* inform upstream about subnets */

As someone reading this code after the fact and not knowing what the hell you are doing, this comment might be a bit confusing. "What subnets?" "I only have my RPL-DODAG based on the DHCPv6-advertised prefix, I don't want any more subnets advertised to the upstream... can I deactivate this?"

Also maybe don't enforce your use case on others ;-).

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/16568#pullrequestreview-693638011
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210628/5910024d/attachment.htm>


More information about the notifications mailing list