[riot-notifications] [RIOT-OS/RIOT] gnrc_ipv6_nib: handle route information option (#16568)

Martine Lenders notifications at github.com
Mon Jun 28 15:08:03 CEST 2021


@miri64 commented on this pull request.



> +    if (final) {
+        ext_opts = _build_final_ext_opts(netif);
+    } else {

> If we advertise ourselves as a default router, we expect _everything_ to be routed via us anyway.

No, only the packets for which no other route can be found. ;-).



> So always adding the RIO will add a superfluous entry to the forwarding table on the downstream node:
> 
> ```
> 2021-06-28 14:58:17,217 # 2001:16b8:4545:1400::/64 via fe80::a4ed:29ff:feec:d5f3 dev #7 // this is not needed
> 2021-06-28 14:58:17,220 # 2001:16b8:4545:14f8::/62 dev #7
> 2021-06-28 14:58:17,220 # 2001:16b8:4545:14fa::/63 dev #6
> 2021-06-28 14:58:17,222 # default via fe80::a4ed:29ff:feec:d5f3 dev #7
> ```
> 
> It doesn't hurt, but takes up some space both in RAM and on the wire.

I thought this was the whole plan? If not and you only want the border router to advertise their downstream route, why not only advertise add the RIO only in the upstream router advertisements of the border router. Much less confusing than tying it to the final router advertisement (which can also happen on a downstream node if the `rtr_adv` or `rtr` flags is unset for whatever reason).

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/16568#discussion_r659769429
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210628/29e382d6/attachment.htm>


More information about the notifications mailing list