[riot-notifications] [RIOT-OS/RIOT] sys/net/dhcpv6: Add IA_NA support to the DHCPv6 client (#16228)

Martine Lenders notifications at github.com
Mon Jun 28 15:12:05 CEST 2021


@miri64 commented on this pull request.



> -        /* then => tgt_netif->aac_mode = GNRC_NETIF_AAC_DHCP; */
-        DEBUG("nib: would set interface %i to DHCPv6, "
-              "but is not implemented yet", netif->pid);
+
+        /* TODO: How will this flag be used? */
+        netif->ipv6.aac_mode = GNRC_NETIF_AAC_DHCP;

> I see, thanks for the clarification :) I was just wondering if the `aac_mode` field should be used or checked for somewhere else or if this more relevant for future implementations

Since this PR introduces IA_NA, it might be good if this is checked. But then again, from what I can see I did not seem to have thought of the case that one would use SLAAC _and_ DHCPv6 for address configuration (`aac_mode` is just an int, not a flag field), so maybe that field needs to be redone as a flag field.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/16228#discussion_r659772598
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210628/e1689ed0/attachment.htm>


More information about the notifications mailing list