[riot-notifications] [RIOT-OS/RIOT] gnrc_ipv6_nib: handle route information option (#16568)

benpicco notifications at github.com
Mon Jun 28 15:38:47 CEST 2021


@benpicco commented on this pull request.



> +    if (final) {
+        ext_opts = _build_final_ext_opts(netif);
+    } else {

I think [this comment](https://github.com/RIOT-OS/RIOT/pull/16568#discussion_r659545433) still applies.
We certainly wouldn't want to add the ABR option when advertising to the upstream network.
None of the options in `_build_ext_opts` make sense when sending a RA upstream - we just got them from there, no need to echo them back. 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/16568#discussion_r659794692
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210628/568a994d/attachment.htm>


More information about the notifications mailing list