[riot-notifications] [RIOT-OS/RIOT] sys/net/dhcpv6: Add IA_NA support to the DHCPv6 client (#16228)

Jan Romann notifications at github.com
Mon Jun 28 20:09:43 CEST 2021

@JKRhb commented on this pull request.

> -        /* then => tgt_netif->aac_mode = GNRC_NETIF_AAC_DHCP; */
-        DEBUG("nib: would set interface %i to DHCPv6, "
-              "but is not implemented yet", netif->pid);
+        /* TODO: How will this flag be used? */
+        netif->ipv6.aac_mode = GNRC_NETIF_AAC_DHCP;

> The comment says `tgt_netif`, so that should be used.

Hmm, the signature of the function is

void _remove_tentative_addr(gnrc_netif_t *netif, const ipv6_addr_t *addr)

should the `netif` be renamed there? So far no `tgt_netif` is present in the file which is why didn't use it.

> Since this PR introduces IA_NA, it might be good if this is checked. But then again, from what I can see I did not seem to have thought of the case that one would use SLAAC and DHCPv6 for address configuration (aac_mode is just an int, not a flag field), so maybe that field needs to be redone as a flag field.

Oh, good point. So in the end the line should look something like this

    netif->ipv6.aac_mode |= GNRC_NETIF_AAC_DHCP;

I guess?

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210628/14d9c785/attachment.htm>

More information about the notifications mailing list