[riot-notifications] [RIOT-OS/RIOT] cpu/stm32: Add Kconfig dependency modeling (#16483)

Leandro Lanzieri notifications at github.com
Tue Jun 29 13:02:43 CEST 2021


@leandrolanzieri commented on this pull request.



> +  USEMODULE += cpp
+  USEMODULE += libstdcpp
+endif
+
+ifneq (,$(filter cpp,$(FEATURES_USED)))
+  # Also use C++ if libstdc++ is used
+  USEMODULE += cpp

I think it makes sense to have `cpp` and `libstdcpp` as pseudomodules which depend on the respective features, but in this case perhaps we want to modify the makefiles to include the module. So instead of `FEATURES_REQUIRED += cpp` a module would `USEMODULE += cpp`. Then, here we would:

```makefile
ifneq (,$(filter libstdcpp,$(USEMODULE)))
  FEATURES_REQUIRED += libstdcpp
  USEMODULE += cpp
endif

ifneq (,$(filter cpp,$(USEMODULE)))
  FEATURES_REQUIRED += cpp
endif
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/16483#pullrequestreview-694889313
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210629/fcad3c99/attachment-0001.htm>


More information about the notifications mailing list