[riot-notifications] [RIOT-OS/RIOT] sys/net/dhcpv6: Add IA_NA support to the DHCPv6 client (#16228)

Martine Lenders notifications at github.com
Tue Jun 29 14:05:27 CEST 2021


@miri64 commented on this pull request.



> +#!/usr/bin/env python3
+
+# Copyright (C) 2018 Freie Universität Berlin
+#
+# This file is subject to the terms and conditions of the GNU Lesser
+# General Public License v2.1. See the file LICENSE in the top level
+# directory for more details.
+
+import os
+import pexpect
+import sys
+import time
+
+from scapy.all import AsyncSniffer, sendp, Ether, IPv6, UDP
+from scapy.all import DHCP6_Solicit, DHCP6_Advertise, DHCP6_Request, DHCP6_Reply
+from scapy.all import DHCP6OptClientId, DHCP6OptServerId, DHCP6OptMudUrl

I would prefer if functionalities are tested separately as faults can then be easily pin-pointed. However, this increases build times and currently these tests are not run automatically since they require root privileges. So just updating `tests/gnrc_dhcpv6_client` might be preferable. You do not add changes to auto-init anyway, right?

To address my first concern of pin-pointing faults, maybe the IA_NA tests can be marked in the output specially with an assert message?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/16228#discussion_r660549823
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210629/3f42ac18/attachment.htm>


More information about the notifications mailing list