[riot-notifications] [RIOT-OS/RIOT] sys/net/dhcpv6: Add IA_NA support to the DHCPv6 client (#16228)

Jan Romann notifications at github.com
Tue Jun 29 16:12:13 CEST 2021


@JKRhb commented on this pull request.



> +#!/usr/bin/env python3
+
+# Copyright (C) 2018 Freie Universität Berlin
+#
+# This file is subject to the terms and conditions of the GNU Lesser
+# General Public License v2.1. See the file LICENSE in the top level
+# directory for more details.
+
+import os
+import pexpect
+import sys
+import time
+
+from scapy.all import AsyncSniffer, sendp, Ether, IPv6, UDP
+from scapy.all import DHCP6_Solicit, DHCP6_Advertise, DHCP6_Request, DHCP6_Reply
+from scapy.all import DHCP6OptClientId, DHCP6OptServerId, DHCP6OptMudUrl

> You do not add changes to auto-init anyway, right?

I added [this](https://github.com/RIOT-OS/RIOT/pull/16228/files#diff-892a732ccdabad2f85826ca80908ed7922efdf2387f52f8ef8707b0835484aeeL122-R140)  to the `thread` function called by `dhcpv6_client_auto_init` but you are right, the other aspects of the auto-init haven't been touched.

> To address my first concern of pin-pointing faults, maybe the IA_NA tests can be marked in the output specially with an assert message?

Oh, I noticed only now that there is an assertion missing for the `IA_NA` part! I will add extend the test and then the new functionality should hopefully be covered :)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/16228#discussion_r660658261
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210629/34b5af11/attachment.htm>


More information about the notifications mailing list