[riot-notifications] [RIOT-OS/RIOT] sx126x: add support for multiple simultaneous variants (#16597)

Leandro Lanzieri notifications at github.com
Wed Jun 30 16:15:06 CEST 2021


@leandrolanzieri commented on this pull request.

Changes look good! Just some minor comments if you agree

> +    SX126X_SX1261,
+    SX126X_SX1262,
+    SX126X_SX1268,
+    SX126X_LLCC68,

Just as a suggestion, have the prefix `SX126X_TYPE_`, similar to the regulator mode enums.

> @@ -0,0 +1,131 @@
+/*
+ * Copyright (C) 2021 Inria

```suggestion
 * Copyright (C) 2021 HAW Hamburg
```

> + * @return    true if @p type matches the variant type
+ * @return    false otherwise

Here and for the rest?

```suggestion
 * @retval    true if @p type matches the variant type
 * @retval    false otherwise
```

> +#if SX126X_SINGLE
+    (void) dev;
+    (void) type;
+    assert(false);
+    return false;

Here and for the rest?
```suggestion
assert(dev);
#if SX126X_SINGLE
    (void) type;
    assert(false);
    return false;
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/16597#pullrequestreview-696208956
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210630/7fcfdfb6/attachment.htm>


More information about the notifications mailing list