[riot-notifications] [RIOT-OS/RIOT] dist/pythonlibs/riotctrl_shell: add loramac shell (#16403)

Martine Lenders notifications at github.com
Mon May 3 10:21:08 CEST 2021


@miri64 requested changes on this pull request.



> +    @ShellInteraction.check_term
+    def loramac_eeprom_save(self, timeout=-1, async_=False):
+        return self.cmd("loramac save", timeout, async_)
+
+    @ShellInteraction.check_term
+    def loramac_eeprom_erase(self, timeout=-1, async_=False):
+        return self.cmd("loramac erase", timeout, async_)
+
+    @ShellInteraction.check_term
+    def loramac_help(self, timeout=-1, async_=False):
+        return self.cmd("loramac help", timeout, async_)

Why can't those use `loramac_cmd`? AFAICS this should be possible:

```suggestion
    @ShellInteraction.check_term
    def loramac_eeprom_save(self, timeout=-1, async_=False):
        return self.loramac_cmd(("save",), timeout, async_)

    @ShellInteraction.check_term
    def loramac_eeprom_erase(self, timeout=-1, async_=False):
        return self.cmd(("erase",), timeout, async_)

    @ShellInteraction.check_term
    def loramac_help(self, timeout=-1, async_=False):
        return self.cmd(("help",), timeout, async_)
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/16403#pullrequestreview-650166872
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210503/b055e38d/attachment.htm>


More information about the notifications mailing list