[riot-notifications] [RIOT-OS/RIOT] build system: Rework EXTERNAL_MODULE_DIRS (#16104)

Francisco notifications at github.com
Tue May 4 12:33:38 CEST 2021


@fjmolinas commented on this pull request.



>        $(warning Using BOARDSDIR is deprecated use EXTERNAL_BOARD_DIRS instead)
       $(info EXTERNAL_BOARD_DIRS can contain multiple folders separated by space)
     endif
+
+    # API change warning for EXTERNAL_MODULE_DIRS, remove by 2021.10
+    ifneq (,$(EXTERNAL_MODULE_DIRS))
+      ifeq (1,$(WARNING_EXTERNAL_MODULE_DIRS))

Does this make sense now? I had added it so that a user that had migrated could disable the warning, but maybe it does not make sense.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/16104#pullrequestreview-651094617
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210504/c61dbc47/attachment.htm>


More information about the notifications mailing list