[riot-notifications] [RIOT-OS/RIOT] build system: Rework EXTERNAL_MODULE_DIRS (#16104)

Francisco notifications at github.com
Tue May 4 16:27:22 CEST 2021


@fjmolinas commented on this pull request.



>        $(warning Using BOARDSDIR is deprecated use EXTERNAL_BOARD_DIRS instead)
       $(info EXTERNAL_BOARD_DIRS can contain multiple folders separated by space)
     endif
+
+    # API change warning for EXTERNAL_MODULE_DIRS, remove by 2021.10
+    ifneq (,$(EXTERNAL_MODULE_DIRS))
+      ifeq (1,$(WARNING_EXTERNAL_MODULE_DIRS))

Ahh, I was just confused because I didn't see the definition, but it's just above, isn't it better to keep it here with where its used (feel free to dismiss, just commenting since with a red Murdock this will require another build anyway)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/16104#discussion_r625829192
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210504/36c7b262/attachment.htm>


More information about the notifications mailing list