[riot-notifications] [RIOT-OS/RIOT] gnrc_ipv6_nib: fix acquire race on gnrc_ipv6_nib_get_next_hop_l2addr() (#16450)

Martine Lenders notifications at github.com
Wed May 5 19:08:01 CEST 2021

@miri64 commented on this pull request.

> @@ -186,6 +186,18 @@ static bool _on_link(const ipv6_addr_t *dst, unsigned *iface)
     return ipv6_addr_is_link_local(dst);
+static gnrc_netif_t *_acquire_new_iface(unsigned iface)

> In line 225 you already have the `netif` pointer

Look at what the comment says: "release pre-assumed netif". This `netif` pointer is a different one from the one we fetch in the line below. The `if` condition in l272 should make clear what I mean.

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210505/e0333279/attachment-0001.htm>

More information about the notifications mailing list