[riot-notifications] [RIOT-OS/RIOT] cpu/atxmega/periph: Add ebi driver (#16288)

Marian Buschsieweke notifications at github.com
Mon May 10 18:11:41 CEST 2021


@maribu commented on this pull request.



> @@ -1,4 +1,5 @@
 USEMODULE += boards_common_atxmega
+USEMODULE += periph_ebi

```suggestion
FEATURES_REQUIRED += periph_ebi
```

But even better would be adding `FEAUTERS_OPTIONAL += periph_ebi` at cpu-level.

The reason is that always both the feature and the corresponding module implementing it should be used, as inconsistency between them can result in broken dependency resolution. By just always pulling in the feature, the corresponding modules will be automatically included.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/16288#pullrequestreview-655824867
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210510/0a1ad272/attachment.htm>


More information about the notifications mailing list