[riot-notifications] [RIOT-OS/RIOT] boards: Adding board support for the Seeeduino XIAO (#16469)

benpicco notifications at github.com
Tue May 11 15:22:15 CEST 2021


@benpicco commented on this pull request.



> +/*
+ * Copyright (C)  2021 Franz Freitag, Justus Krebs, Nick Weiler 
+ *
+ * This file is subject to the terms and conditions of the GNU Lesser
+ * General Public License v2.1. See the file LICENSE in the top level
+ * directory for more details.
+ */
+
+/**
+ * @ingroup     boards_seeedurino_XIAO
+ * @{
+ *
+ * @file
+ * @brief       Board specific implementations for the Seeeduino XIAO board
+ *
+ * @author      Franz Freitag <franz.freitag at st.ovgu.de>, Justus Krebs <justus.krebs at st.ovgu.de>, Nick Weiler <nick.weiler at st.ovgu.de>, Benjamin Valentin <benpicco at googlemail.com>

add some line breaks here

> +/* GD25Q32C */
+static const mtd_spi_nor_params_t _seeduino_XIAO_nor_params = {

Does the board really have SPI flash?
I didn't find it on the [schematics](https://files.seeedstudio.com/wiki/Seeeduino-XIAO/res/Seeeduino-XIAO-v1.0-SCH-191112.pdf)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/16469#pullrequestreview-656694417
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210511/2f169b71/attachment.htm>


More information about the notifications mailing list