[riot-notifications] [RIOT-OS/RIOT] boards: Adding board support for the Seeeduino XIAO (#16469)

Marian Buschsieweke notifications at github.com
Wed May 12 13:58:38 CEST 2021


@maribu commented on this pull request.

Very nice first pull request! I have a bunch style nit-picks.

> @@ -0,0 +1,73 @@
+/*
+ * Copyright (C)  2021 Franz Freitag, Justus Krebs, Nick Weiler 

```suggestion
 * Copyright (C)  2021 Franz Freitag, Justus Krebs, Nick Weiler
```

(remove trailing whitespace)

> +/*
+ * Copyright (C)  2021 Franz Freitag, Justus Krebs, Nick Weiler 
+ *
+ * This file is subject to the terms and conditions of the GNU Lesser
+ * General Public License v2.1. See the file LICENSE in the top level
+ * directory for more details.
+ */
+
+/**
+ * @ingroup     boards_seeedurino_XIAO
+ * @{
+ *
+ * @file
+ * @brief       Board specific implementations for the Seeeduino XIAO board
+ *
+ * @author      Franz Freitag <franz.freitag at st.ovgu.de>, Justus Krebs <justus.krebs at st.ovgu.de>, Nick Weiler <nick.weiler at st.ovgu.de>, Benjamin Valentin <benpicco at googlemail.com>

```suggestion
 * @author      Franz Freitag <franz.freitag at st.ovgu.de>
 * @author      Justus Krebs <justus.krebs at st.ovgu.de>
 * @author      Nick Weiler <nick.weiler at st.ovgu.de>
 * @author      Benjamin Valentin <benpicco at googlemail.com>
```

I think those need to be one command per author

> @@ -0,0 +1,37 @@
+/**
+ at defgroup    boards_seeeduino_XIAO Seeeduino_XIAO
+ at ingroup     boards
+ at brief       Support for the Seeeduino XIAO.
+
+### General information
+
+The Seeeduino XIAO is the smallest member of the Seeeduino family. It carries the powerful ATSAMD21G18A-MU which is a low-power microcontrollers. On the other hand, this little board has good performance in processing but needs less power. As a matter of fact, it is designed in a tiny size and can be used for wearable devices and small projects.
+
+Seeeduino XIAO has 14 GPIO PINs, which can be used for 11 digital interfaces, 11 mock interfaces, 10 PWM interfaces (d1-d10), 1 DAC output pin D0, 1 SWD pad interface, 1 I2C interface, 1 SPI interface, 1 UART interface, Serial communication indicator (T/R), Blink light (L). The colors of LEDs(Power,L,RX,TX) are green, yellow, blue and blue. Moreover, Seeeduino XIAO has a Type-C interface which can supply power and download code. There are two reset button, you can short connect them to reset the board.
+
+-- General discription of the [wiki](https://wiki.seeedstudio.com/Seeeduino-XIAO/)

```suggestion
-- General description of the [wiki](https://wiki.seeedstudio.com/Seeeduino-XIAO/)
```

> +Use `BOARD=seeeduino_XIAO` with the `make` command.<br/>
+Example with `default` application:

```suggestion
Use `BOARD=seeeduino_XIAO` with the `make` command.

Example with `default` application:
```

Maybe just add an empty line to start a new paragraph?

> @@ -0,0 +1,101 @@
+/*
+ * Copyright (C) 2021 Franz Freitag, Justus Krebs, Nick Weiler 

```suggestion
 * Copyright (C) 2021 Franz Freitag, Justus Krebs, Nick Weiler
```

> + * Copyright (C) 2021 Franz Freitag, Justus Krebs, Nick Weiler 
+ *
+ * This file is subject to the terms and conditions of the GNU Lesser
+ * General Public License v2.1. See the file LICENSE in the top level
+ * directory for more details.
+ */
+
+/**
+ * @ingroup     boards_seeeduino_XIAO
+ * @brief       Support for the Seeeduino XIAO board.
+ * @{
+ *
+ * @file
+ * @brief       Board specific definitions for the Seeeduino XIAO
+ *
+ * @author      Franz Freitag <franz.freitag at st.ovgu.de>, Justus Krebs <justus.krebs at st.ovgu.de>, Nick Weiler <nick.weiler at st.ovgu.de>, Benjamin Valentin <benpicco at googlemail.com>

```suggestion
 * @author      Franz Freitag <franz.freitag at st.ovgu.de>
 * @author      Justus Krebs <justus.krebs at st.ovgu.de>
 * @author      Nick Weiler <nick.weiler at st.ovgu.de>
 * @author      Benjamin Valentin <benpicco at googlemail.com>
```

> +/*
+ * Copyright (C)  2021 Franz Freitag, Justus Krebs, Nick Weiler
+ *
+ * This file is subject to the terms and conditions of the GNU Lesser
+ * General Public License v2.1. See the file LICENSE in the top level
+ * directory for more details.
+ */
+
+/**
+ * @ingroup     boards_seeeduino_XIAO
+ * @{
+ *
+ * @file
+ * @brief       Board specific configuration of direct mapped GPIOs
+ *
+ * @author     Franz Freitag <franz.freitag at st.ovgu.de>, Justus Krebs <justus.krebs at st.ovgu.de>, Nick Weiler <nick.weiler at st.ovgu.de>, Benjamin Valentin <benpicco at googlemail.com>

```suggestion
 * @author      Franz Freitag <franz.freitag at st.ovgu.de>
 * @author      Justus Krebs <justus.krebs at st.ovgu.de>
 * @author      Nick Weiler <nick.weiler at st.ovgu.de>
 * @author      Benjamin Valentin <benpicco at googlemail.com>
```

> +/*
+ * Copyright (C)  2021 Franz Freitag, Justus Krebs, Nick Weiler
+ *
+ * This file is subject to the terms and conditions of the GNU Lesser
+ * General Public License v2.1. See the file LICENSE in the top level
+ * directory for more details.
+ */
+
+/**
+ * @ingroup     boards_seeeduino_XIAO
+ * @{
+ *
+ * @file
+ * @brief       Configuration of CPU peripherals for the Serpente board
+ *
+ * @author      Franz Freitag <franz.freitag at st.ovgu.de>, Justus Krebs <justus.krebs at st.ovgu.de>, Nick Weiler <nick.weiler at st.ovgu.de>, Benjamin Valentin <benpicco at googlemail.com>

```suggestion
 * @author      Franz Freitag <franz.freitag at st.ovgu.de>
 * @author      Justus Krebs <justus.krebs at st.ovgu.de>
 * @author      Nick Weiler <nick.weiler at st.ovgu.de>
 * @author      Benjamin Valentin <benpicco at googlemail.com>
```

> +    /* port, pin, muxpos */
+    {GPIO_PIN(PA, 2), ADC_INPUTCTRL_MUXPOS_PIN0},
+    {GPIO_PIN(PA, 4), ADC_INPUTCTRL_MUXPOS_PIN4},
+    {GPIO_PIN(PA, 5), ADC_INPUTCTRL_MUXPOS_PIN5},
+    {GPIO_PIN(PA, 6), ADC_INPUTCTRL_MUXPOS_PIN6},
+    {GPIO_PIN(PA, 7), ADC_INPUTCTRL_MUXPOS_PIN7},
+    {GPIO_PIN(PA, 8), ADC_INPUTCTRL_MUXPOS_PIN16},
+    {GPIO_PIN(PA, 9), ADC_INPUTCTRL_MUXPOS_PIN17},
+    {GPIO_PIN(PB, 8), ADC_INPUTCTRL_MUXPOS_PIN2},
+    {GPIO_PIN(PB, 9), ADC_INPUTCTRL_MUXPOS_PIN3}
+};
+
+#define ADC_NUMOF           ARRAY_SIZE(adc_channels)
+/** @} */
+
+

```suggestion
```

> @@ -0,0 +1,73 @@
+/*
+ * Copyright (C)  2021 Franz Freitag, Justus Krebs, Nick Weiler 
+ *
+ * This file is subject to the terms and conditions of the GNU Lesser
+ * General Public License v2.1. See the file LICENSE in the top level
+ * directory for more details.
+ */
+
+/**
+ * @ingroup     boards_seeedurino_XIAO

```suggestion
 * @ingroup     boards_seeeduino_XIAO
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/16469#pullrequestreview-657788094
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210512/136aadd5/attachment-0001.htm>


More information about the notifications mailing list