[riot-notifications] [RIOT-OS/RIOT] core: forward declare msg_t in thread.h (#16477)

Martine Lenders notifications at github.com
Tue May 18 11:37:34 CEST 2021


@miri64 commented on this pull request.



> @@ -163,6 +162,11 @@ extern "C" {
  */
 typedef void *(*thread_task_func_t)(void *arg);
 
+/**
+ * @brief Forward declaration of msg_t

I _think_ if you use `@ref struct msg` here, doxygen will correctly render it. All in all, it would be nice to have a link to the actual struct, since this is in a completely different header.

> @@ -168,7 +168,7 @@
 #include <stdint.h>
 #include <stdbool.h>
 
-#include "sched.h"
+#include "thread.h"

```suggestion
#include "thread.h"    /* include forward declaration of `msg_t`. */
```

?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/16477#pullrequestreview-661859121
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210518/6c279259/attachment.htm>


More information about the notifications mailing list