[riot-notifications] [RIOT-OS/RIOT] tests/disp_dev: improve genericity of application + optimize screen refresh (#16479)

Alexandre Abadie notifications at github.com
Wed May 19 10:08:58 CEST 2021

The RIOT community cares a lot about code quality.
Therefore, before describing what your contribution is about, we would like
you to make sure that your modifications are compliant with the RIOT
coding conventions, see https://github.com/RIOT-OS/RIOT/wiki/Coding-conventions.

### Contribution description

This PR improves the `tests/disp_dev` test application in order to remove the explicit dependency to the ili9341 module by using `auto_init_screen` and the related API.

There's also a small optimization of the screen refresh: apply the null pixel by lines instead of pixel by pixel. This is much faster but needs a buffer (so increase memory usage).

I'm also wondering if `auto_init_screen` shouldn't be made a default module when disp_dev is used. This would simplify the application Makefile again but would enforce all display device with a `disp_dev` adaption layer to provide an `auto_init` function. Thoughts ?

Put here the description of your contribution:
- describe which part(s) of RIOT is (are) involved
- if it's a bug fix, describe the bug that it solves and how it is solved
- you can also give more information to reviewers about how to test your changes

### Testing procedure

- A green Murdock
- Tested on adafruit-clue and the RIOT logo is displayed as expected (but faster)

Details steps to test your contribution:
- which test/example to compile for which board and is there a 'test' command
- how to know that it was not working/available in master
- the expected success test output

### Issues/PRs references

Thought of it after reviewing #12509 

Examples: Fixes #1234. See also #5678. Depends on PR #9876.

Please use keywords (e.g., fixes, resolve) with the links to the issues you
resolved, this way they will be automatically closed when your pull request
is merged. See https://help.github.com/articles/closing-issues-using-keywords/.

You can view, comment on, or merge this pull request online at:


-- Commit Summary --

  * tests/disp_dev: use auto_init_screen
  * tests/disp_dev: improve screen cleanup speed

-- File Changes --

    M tests/disp_dev/Makefile (2)
    M tests/disp_dev/main.c (40)

-- Patch Links --


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210519/e6dc6c92/attachment.htm>

More information about the notifications mailing list