[riot-notifications] [RIOT-OS/RIOT] black/white e-Paper/e-Ink display driver (#12509)

Alexandre Abadie notifications at github.com
Wed May 19 14:05:26 CEST 2021


@aabadie commented on this pull request.



> @@ -0,0 +1,10 @@
+BOARD ?= nucleo-f411re
+
+include ../Makefile.tests_common
+
+USEMODULE += xtimer
+USEMODULE += epd_bw_spi
+
+INCLUDES += -I$(APPDIR)

> How would removing the header file lead to this application not working with a board having an e-paper display?

No, I meant that keeping the header file you added would forbid this: it will fail with the CI (because of redefined defines).

> I don't think it makes any sense: my personal setup can't be included explicitly, but it's fine to do it implicitly as driver defaults?

I said for convenience with your setup. Since you are contributing this driver, then it's ok to have these defaults. And other users (or boards support) are still allowed to provide their own setup. In the current state of this PR, this is not possible without modifying the RIOT codebase (which is annoying).

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/12509#discussion_r635172964
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210519/ea6c3479/attachment.htm>


More information about the notifications mailing list