[riot-notifications] [RIOT-OS/RIOT] black/white e-Paper/e-Ink display driver (#12509)

Alexandre Abadie notifications at github.com
Wed May 19 14:22:36 CEST 2021


@aabadie commented on this pull request.



> +void epd_bw_spi_wait(epd_bw_spi_params_t *p, uint32_t usec)
+{
+    if (p->busy_pin != GPIO_UNDEF) {
+        DEBUG("[epd_bw_spi] wait: for busy bin\n");
+        while (gpio_read(p->busy_pin)) {}
+    }
+    else {
+        DEBUG("[epd_bw_spi] wait: for %" PRIu32 " microseconds\n", usec);
+        xtimer_usleep(usec);
+    }
+}
+
+int epd_bw_spi_init(epd_bw_spi_t *dev,
+                    const epd_bw_spi_params_t *params,
+                    const epd_bw_spi_controller_t *controller,
+                    uint8_t size_x, uint16_t size_y,

size_x and size_y are set via the params (and there is a mismatch between values set in the different controller structs and these values). Same for the controller, there could be one `epd_bw_spi_controller_t` attribute in the params.
Then the signature of the `epd_bw_spi_init` function would be consistent with most of other drivers: `
int epd_bw_spi_init(epd_bw_spi_t *dev, const epd_bw_spi_params_t *params);`.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/12509#pullrequestreview-663126875
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210519/1ea5549c/attachment.htm>


More information about the notifications mailing list